From 4b1e292ae448ab519d0681b49da7420130b5f312 Mon Sep 17 00:00:00 2001 From: Manlio Perillo Date: Sat, 29 Apr 2023 16:25:58 +0200 Subject: [PATCH] test: fix deadlock on windows when running tests The deadlock was caused by setting stdout behavior to ignore, when spawning the patch command. When the patch command writes to devnull it causes some errors and a deadlock. The cause of the bug is probably Zig using `\Device\Null` from `ntdll` while git-bash uses `NUL` from `kernel32`. --- test/tests.zig | 1 - 1 file changed, 1 deletion(-) diff --git a/test/tests.zig b/test/tests.zig index f91c4fd..f166fc2 100644 --- a/test/tests.zig +++ b/test/tests.zig @@ -336,7 +336,6 @@ fn heal(allocator: Allocator, exercises: []const Exercise, outdir: []const u8) ! const argv = &.{ "patch", "-i", patch, "-o", output, file }; var child = std.process.Child.init(argv, allocator); - child.stdout_behavior = .Ignore; // the POSIX standard says that stdout is not used _ = try child.spawnAndWait(); } }